Fix malformed fallback streaming URL #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PattaFeuFeu
force-pushed
the
bugfix/#530/fallback-url-streaming-api-missing-colon-dash
branch
from
45eac7f to
041f938
Compare
PattaFeuFeu
force-pushed
the
bugfix/#530/fallback-url-streaming-api-missing-colon-dash
branch
2 times, most recently
from
d403e08 to
5699d3e
Compare
PattaFeuFeu
force-pushed
the
bugfix/#530/fallback-url-streaming-api-missing-colon-dash
branch
from
5699d3e to
7ad00bc
Compare
PattaFeuFeu
deleted the
bugfix/#530/fallback-url-streaming-api-missing-colon-dash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A user of the library mentioned in #530 that the streaming fallback URL is malformed in that it doesn’t contain
://, e.g.httpsmastodon.socialinstead ofhttps://mastodon.social.This PR ensures that the URL follows URL specifications by using
HttpUrlto create a URL.To not always run the builder, I’ve put it into a lambda that is only called if the fallback URL is actually necessary.
An easier way would be to just write
$scheme://$instanceNamebut I decided against it so that OKHTTPHttpUrlis used on both ends, ensuring compatibility.Closes #530
Type of Change
Breaking Changes
How Has This Been Tested?
I’ve added three new unit tests to test the main success case and the two fallback cases.
Mandatory Checklist
gradle checkand there were no errors reported